Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove OCR Support #2838

Merged
merged 7 commits into from
Dec 15, 2023
Merged

feat: Remove OCR Support #2838

merged 7 commits into from
Dec 15, 2023

Conversation

michael-genson
Copy link
Collaborator

What type of PR is this?

(REQUIRED)

  • cleanup

What this PR does / why we need it:

(REQUIRED)

This removes OCR from Mealie. This is done for a few reasons:

  • The current OCR implementation is half-baked; there are several issues with it that usually make it easier to just type your recipes manually
  • Discussion in Discord heavily leans towards no one using it, or it not working (which is the closest thing we have to actual usage data)
  • Removing it helps focus contributor attention (it's currently one of the more complex features with the most bugs)
  • Removing it drastically lowers build times, container sizes, and resource usage

Which issue(s) this PR fixes:

(REQUIRED)

Closes #2394
Closes #2424
Closes #2437
Closes #2451

Special notes for your reviewer:

(fill-in or delete this section)

I removed the is_ocr_recipe field from the schema, but left it in the db (since we can't easily remove it from sqlite). I also left all of the translations and the mdi-icons, in case we're able to re-purpose them. Happy to remove those if needed.

Kuchenpirat
Kuchenpirat reviewed Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@Kuchenpirat Kuchenpirat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe run make docs to remove the ocr endpoints from the api references

Kuchenpirat
Kuchenpirat approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@Kuchenpirat Kuchenpirat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.
Will not merge yet, as maybe somebody with more experience should have another go

hay-kot
hay-kot approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@hay-kot hay-kot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LET'S GOOOOOOOOOO

@hay-kot hay-kot merged commit ca9f66e into mealie-recipes:mealie-next Dec 15, 2023
6 checks passed
This was referenced Dec 15, 2023
Closed
Closed
Closed
Closed
@Miroito
Copy link
Contributor

Miroito commented Dec 18, 2023

I know we have our differences and as the person that wrote this feature and lost interest in maintaining it due to multiple factors, I agree fully with this decision from your point of view and I respect it. I'll continue to use mealie as long as it is the better open source recipe manager which I think that it still is.
Sometimes goals are not achieved and it's more courageous to give up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hay-kot hay-kot hay-kot approved these changes

@Kuchenpirat Kuchenpirat Kuchenpirat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@michael-genson @Miroito @Kuchenpirat @hay-kot